commit 6d73dc1bf8b1ca933299d39b15ab4d69bee711f4
author Dhruv Srivastava <dhruvsri@google.com> Fri May 30 08:51:55 2025 -0700
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri May 30 08:51:55 2025 -0700
tree 2009cb08035b9e2a6fcab9cfd3cca0e4ad100fd8
parent ab38f3ae521cab9f7f6bcf63a14b2708c3556390
parent a876c4dee7e17db42478d0477fecab576480cf52

Merge "Disable Cherry pick button if no change is selected"

polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts

diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts
index b1e639e..c2faa0c 100644
--- a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts
+++ b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts
@@ -461,7 +461,10 @@
 
   // Private but used in tests
   async sectionsChanged() {
-    this.cursor.stops = await this.getListItems();
+    // Ensure we have a valid array for cursor.stops even if getListItems() returns undefined
+    // This prevents TypeError when forEach is called on cursor.stops
+    const items = await this.getListItems();
+    this.cursor.stops = items ?? [];
     this.cursor.moveToStart();
     if (this.selectedIndex) this.cursor.setCursorAtIndex(this.selectedIndex);
   }